On Wed, Jun 5, 2024 at 7:35 PM Dmitry Safonov <0x7f454c46@xxxxxxxxx> wrote: > > Hi Eric, > > Thanks for the review, > > On Wed, 5 Jun 2024 at 09:07, Eric Dumazet <edumazet@xxxxxxxxxx> wrote: > > > > On Wed, Jun 5, 2024 at 4:20 AM Dmitry Safonov via B4 Relay > > <devnull+0x7f454c46.gmail.com@xxxxxxxxxx> wrote: > > > > > > From: Dmitry Safonov <0x7f454c46@xxxxxxxxx> > > > > > > Two reasons: > > > 1. It's grown up enough > > > 2. In order to not do header spaghetti by including > > > <trace/events/tcp.h>, which is necessary for TCP tracepoints. > > > > > > Signed-off-by: Dmitry Safonov <0x7f454c46@xxxxxxxxx> > > > > Then we probably do not need EXPORT_SYMBOL(tcp_inbound_md5_hash); anymore ? > > Certainly, my bad. I will remove that in v3. > No problem, also make it static, in case this was not clear from my comment.
