On Tue, May 14, 2024 at 8:56 AM Pasha Tatashin <pasha.tatashin@xxxxxxxxxx> wrote: > > On Tue, May 14, 2024 at 9:35 AM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > > > > Add version string at the beginning of /proc/allocinfo to allow later > > format changes. Exampe output: > > > > > head /proc/allocinfo > > allocinfo - version: 1.0 > > 0 0 init/main.c:1314 func:do_initcalls > > 0 0 init/do_mounts.c:353 func:mount_nodev_root > > 0 0 init/do_mounts.c:187 func:mount_root_generic > > 0 0 init/do_mounts.c:158 func:do_mount_root > > 0 0 init/initramfs.c:493 func:unpack_to_rootfs > > 0 0 init/initramfs.c:492 func:unpack_to_rootfs > > 0 0 init/initramfs.c:491 func:unpack_to_rootfs > > 512 1 arch/x86/events/rapl.c:681 func:init_rapl_pmus > > 128 1 arch/x86/events/rapl.c:571 func:rapl_cpu_online > > It would be also useful to add a header line: > > $ head /proc/allocinfo > allocinfo - version: 1.0 > # <size> <calls> <tag> > 0 0 init/main.c:1314 func:do_initcalls > 0 0 init/do_mounts.c:353 func:mount_nodev_root > 0 0 init/do_mounts.c:187 func:mount_root_generic > 0 0 init/do_mounts.c:158 func:do_mount_root > ... > > This would be the same as in /proc/slabinfo: > $ sudo head /proc/slabinfo > slabinfo - version: 2.1 > # name <active_objs> <num_objs> <objsize> <objperslab> > <pagesperslab> : tunables <limit> <batchcount> <sharedfactor> : > slabdata <active_slabs> <num_slabs> <sharedavail> > pid_3 2730 2730 192 42 2 : tunables 0 0 > 0 : slabdata 65 65 0 > .. Thanks! Addressed in v2: https://lore.kernel.org/all/20240514163128.3662251-1-surenb@xxxxxxxxxx/ > > Pasha