Re: [PATCH net-next v9 2/4] ethtool: provide customized dim profile management

[Heng Qi <hengqi@xxxxxxxxxxxxxxxxx>]

@@ -227,7 +315,19 @@ const struct nla_policy ethnl_coalesce_set_policy[] = {
> > > >    	[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES] = { .type = NLA_U32 },
> > > >    	[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES] = { .type = NLA_U32 },
> > > >    	[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS] = { .type = NLA_U32 },
> > > > +	[ETHTOOL_A_COALESCE_RX_EQE_PROFILE]     = { .type = NLA_NESTED },
> > > > +	[ETHTOOL_A_COALESCE_RX_CQE_PROFILE]     = { .type = NLA_NESTED },
> > > > +	[ETHTOOL_A_COALESCE_TX_EQE_PROFILE]     = { .type = NLA_NESTED },
> > > > +	[ETHTOOL_A_COALESCE_TX_CQE_PROFILE]     = { .type = NLA_NESTED },
> > > NLA_POLICY_NESTED(coalesce_set_profile_policy)
> > This doesn't work because the first level of sub-nesting of
> > ETHTOOL_A_COALESCE_RX_CQE_PROFILE is ETHTOOL_A_PROFILE_IRQ_MODERATION.
> So declare a policy for IRQ_MODERATION which has one entry -> nested
> profile policy?

Still doesn't work because one profile corresponds to 5 IRQ_MODERATION sub-nests.

In the same example, strset also uses NLA_NESTED.

Thanks.