Re: [PATCH net-next v4 03/12] net: ethernet: oa_tc6: implement register read operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Parthiban Veerasooran <Parthiban.Veerasooran@xxxxxxxxxxxxx>
Subject: Re: [PATCH net-next v4 03/12] net: ethernet: oa_tc6: implement register read operation
From: Andrew Lunn <andrew@xxxxxxx>
Date: Wed, 24 Apr 2024 01:17:04 +0200
Cc: davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, horms@xxxxxxxxxx, saeedm@xxxxxxxxxx, anthony.l.nguyen@xxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, corbet@xxxxxxx, linux-doc@xxxxxxxxxxxxxxx, robh+dt@xxxxxxxxxx, krzysztof.kozlowski+dt@xxxxxxxxxx, conor+dt@xxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, horatiu.vultur@xxxxxxxxxxxxx, ruanjinjie@xxxxxxxxxx, steen.hegelund@xxxxxxxxxxxxx, vladimir.oltean@xxxxxxx, UNGLinuxDriver@xxxxxxxxxxxxx, Thorsten.Kummermehr@xxxxxxxxxxxxx, Pier.Beruto@xxxxxxxxxx, Selvamani.Rajagopal@xxxxxxxxxx, Nicolas.Ferre@xxxxxxxxxxxxx, benjamin.bigler@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20240418125648.372526-4-Parthiban.Veerasooran@microchip.com>
References: <20240418125648.372526-1-Parthiban.Veerasooran@microchip.com> <20240418125648.372526-4-Parthiban.Veerasooran@microchip.com>

> +static int oa_tc6_check_ctrl_read_reply(struct oa_tc6 *tc6, u8 size)
> +{
> +	u32 *tx_buf = tc6->spi_ctrl_tx_buf;
> +	u32 *rx_buf = tc6->spi_ctrl_rx_buf + OA_TC6_CTRL_IGNORED_SIZE;

Reverse christmas tree. Those two need swapping around.

	Andrew

Follow-Ups:
- Re: [PATCH net-next v4 03/12] net: ethernet: oa_tc6: implement register read operation
  - From: Parthiban.Veerasooran

References:
- [PATCH net-next v4 00/12] Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface
  - From: Parthiban Veerasooran
- [PATCH net-next v4 03/12] net: ethernet: oa_tc6: implement register read operation
  - From: Parthiban Veerasooran

Prev by Date: Re: [PATCH net-next v4 02/12] net: ethernet: oa_tc6: implement register write operation
Next by Date: Re: [PATCH net-next v4 04/12] net: ethernet: oa_tc6: implement software reset
Previous by thread: [PATCH net-next v4 03/12] net: ethernet: oa_tc6: implement register read operation
Next by thread: Re: [PATCH net-next v4 03/12] net: ethernet: oa_tc6: implement register read operation
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]