On Wed, Apr 17, 2024 at 11:53:44AM +0300, Danielle Ratson wrote:
...
> +/**
> + * struct ethtool_cmis_cdb_cmd_args - CDB commands execution arguments
> + * @req: CDB command fields as described in the CMIS standard.
> + * @max_duration: Maximum duration time for command completion in msec.
> + * @read_write_len_ext: Allowable additional number of byte octets to the LPL
> + * in a READ or a WRITE commands.
> + * @rpl_exp_len: Expected reply length in bytes.
> + * @flags: Validation flags for CDB commands.
> + */
Hi Danielle,
I'm fine if this gets addressed as a follow-up,
but the Kernel doc above should include documentation
of msleep_pre_rpl and err_msg.
Flagged by: ./scripts/kernel-doc -Wall -none
> +struct ethtool_cmis_cdb_cmd_args {
> + struct ethtool_cmis_cdb_request req;
> + u16 max_duration;
> + u8 read_write_len_ext;
> + u8 msleep_pre_rpl;
> + u8 rpl_exp_len;
> + u8 flags;
> + char *err_msg;
> +};
...
