On Tue, 2024-04-09 at 20:09 +0100, Mark Brown wrote: > On Tue, Apr 09, 2024 at 07:41:05PM +0100, Ruben Wauters wrote: > > > This is my first patch, so I hope I did everything right, please > > let > > me know if I need to change something, and I shall endevour to do > > it > > properly. > > Everything looks good, only issue I can see is that this question > (which > is adminstrative stuff rather than part of the changelog) should have > gone after the --- below: > > > > > Signed-off-by: Ruben Wauters <rubenru09@xxxxxxx> > > --- > > so that tooling can automatically remove it when applying. > > However a patch for this issue has already been applied but not yet > merged into Linus' tree. My apologies, I should have checked before submitting the patch, will do this in the future, and noted on the message, will also keep that in mind.