On Tue, 2 Apr 2024 08:28:34 -0500 Rob Herring <robh@xxxxxxxxxx> wrote: > > + patternProperties: > > + "^manager@0[0-9]|1[0-2]$": > > Unit-addresses are typically in hex. > > Is 'manager' something specific to this device or should be common? Specific to this device. > > + $ref: /schemas/graph.yaml#/properties/ports > > This is not using the graph binding. Furthermore, I don't want to see > new cases of 'port' node names which are not graph nodes. We have it > already with ethernet switches, but 'ethernet-port' is preferred over > 'port'. Ok I will remove the ref then. > Why is this one 'managers' and the other device binding 'channels'? Here each manager can have up to 8 ports. The ports in tps23881 are called channels in the datasheet but I can use the port naming for both if you prefer. > > + description: > > + PD69208T4/PD69204T4/PD69208M PSE manager exposing 4 or 8 physical > > + ports. > > + > > + properties: > > + reg: > > + description: > > + Incremental index of the PSE manager starting from 0, ranging > > + from lowest to highest chip select, up to 12. > > + maxItems: 1 > > + > > + patternProperties: > > + '^port@[0-7]$': > > + type: object > > + required: > > + - reg > > Any property you want is allowed in this node. You are missing > 'additionalProperties'. Indeed. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
