Hi, On 4/2/24 4:30 PM, Armin Wolf wrote: > The inspur_platform_profile driver and the xiaomi-wmi driver both > meet the requirements for modern WMI drivers, as they both do not > use the legacy GUID-based interface and can be safely instantiated > multiple times. > > Mark them both as legacy-free using the no_singleton flag. > > Compile-tested only. > > Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> > Signed-off-by: Armin Wolf <W_Armin@xxxxxx> Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > Changes since v1: > - add Reviewed-by tag > --- > drivers/platform/x86/inspur_platform_profile.c | 1 + > drivers/platform/x86/xiaomi-wmi.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/platform/x86/inspur_platform_profile.c b/drivers/platform/x86/inspur_platform_profile.c > index 743705bddda3..8440defa6788 100644 > --- a/drivers/platform/x86/inspur_platform_profile.c > +++ b/drivers/platform/x86/inspur_platform_profile.c > @@ -207,6 +207,7 @@ static struct wmi_driver inspur_wmi_driver = { > .id_table = inspur_wmi_id_table, > .probe = inspur_wmi_probe, > .remove = inspur_wmi_remove, > + .no_singleton = true, > }; > > module_wmi_driver(inspur_wmi_driver); > diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiaomi-wmi.c > index 54a2546bb93b..1f5f108d87c0 100644 > --- a/drivers/platform/x86/xiaomi-wmi.c > +++ b/drivers/platform/x86/xiaomi-wmi.c > @@ -83,6 +83,7 @@ static struct wmi_driver xiaomi_wmi_driver = { > .id_table = xiaomi_wmi_id_table, > .probe = xiaomi_wmi_probe, > .notify = xiaomi_wmi_notify, > + .no_singleton = true, > }; > module_wmi_driver(xiaomi_wmi_driver); > > -- > 2.39.2 >
