On Tue, 2 Apr 2024 13:52:01 -0700 Rahul Rameshbabu wrote: > +/** > + * struct ethtool_ts_stats - HW timestamping statistics > + * @tx_stats: struct group for TX HW timestamping > + * @pkts: Number of packets successfully timestamped by the hardware. > + * @lost: Number of hardware timestamping requests where the timestamping > + * information from the hardware never arrived for submission with > + * the skb. > + * @err: Number of arbitrary timestamp generation error events that the > + * hardware encountered, exclusive of @lost statistics. Cases such > + * as resource exhaustion, unavailability, firmware errors, and > + * detected illogical timestamp values not submitted with the skb > + * are inclusive to this counter. > + */ > +struct ethtool_ts_stats { > + struct_group(tx_stats, Doesn't seem like the group should be documented: include/linux/ethtool.h:503: warning: Excess struct member 'tx_stats' description in 'ethtool_ts_stats' -- pw-bot: cr