On Thu, 28 Mar 2024 10:40:11 +0000 Simon Horman <horms@xxxxxxxxxx> wrote: > On Thu, Mar 28, 2024 at 10:33:22AM +0000, Simon Horman wrote: > > On Tue, Mar 26, 2024 at 03:04:47PM +0100, Kory Maincent wrote: > > > From: Kory Maincent (Dent Project) <kory.maincent@xxxxxxxxxxx> > > ... > > > > diff --git a/include/linux/pse-pd/pse.h b/include/linux/pse-pd/pse.h > > > > ... > > > > > @@ -73,11 +103,11 @@ struct pse_control; > > > * @pse_control_head: head of internal list of requested PSE controls > > > * @dev: corresponding driver model device struct > > > * @of_pse_n_cells: number of cells in PSE line specifiers > > > - * @of_xlate: translation function to translate from specifier as found > > > in the > > > - * device tree to id as given to the PSE control ops > > > * @nr_lines: number of PSE controls in this controller device > > > * @lock: Mutex for serialization access to the PSE controller > > > * @types: types of the PSE controller > > > + * @pi: table of PSE PIs described in this controller device > > > + * @of_legacy: flag set if the pse_pis devicetree node is not used > > > > nit: it looks line the documentation didn't keep up with the > > structure during development: @no_of_pse_pi should be > > documented instead of @of_legacy. > > There seem to be some similar minor problems in > [PATCH net-next v6 13/17] net: pse-pd: Use regulator framework within PSE > framework > > ./scripts/kernel-doc -none is your friend here. Oh didn't know about it, thanks! Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
