On Sat, 2024-03-23 at 20:43 +0000, Matthew Wilcox wrote: > On Sat, Mar 23, 2024 at 10:01:47PM +0530, Amogh Cheluvaraj wrote: > > Fix duplicate C declaration warnings at > > Documentation/gpu/drm-kms.rst that was found by > > compiling htmldocs > > I'm sure this removes the warning, but it removes all kernel-doc > which exists in drivers/gpu/drm/drm_fourcc.c. Isn't there a more > granular fix than this? > After further introspection of the file drivers/gpu/drm/drm_fourcc.c, I found that the warning is caused by having the same name for both the struct and the function as in "const struct drm_format_info *drm_format_info(u32 format)". This is an issue found using the latest version of Sphinx as reported by Akira Yokosawa in message id 564cbd05-8788-9223-1ecc-59e7fc41b46a@xxxxxxxxx. So by changing the function name to something like "query_drm_format_info(u32 format)" is a possible fix. Question is what should I rename this function to, that aligns with the coding standards? Also suggest a new function name for "drm_modeset_lock" that causes the second warning.
