On Sat, 23 Mar 2024 07:55:52 -0700, Randy Dunlap wrote: > Hi Akira, Thank you for your comments, Randy. > > On 3/23/24 05:02, Akira Yokosawa wrote: >> xelatex doesn't understand variable font format. Recent deployment >> of variable Noto CJK fonts in Fedora and openSUSE tumbleweed breaks >> builds of translations.pdf. >> >> To help developers work around the build error, add a script for >> checking existence of variable form of those fonts and emitting >> suggestions. Invoke it in the error path of "make pdfdocs" so that it >> is activated only when PDF build actually fails. >> >> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx> >> Reported-by: Jonathan Corbet <corbet@xxxxxxx> >> Link: https://lore.kernel.org/r/8734tqsrt7.fsf@xxxxxxxxxxxx/ >> Reported-by: "Иван Иванович" <relect@xxxxx> >> Link: https://lore.kernel.org/linux-doc/1708585803.600323099@xxxxxxxxxxxxxx/ >> --- > > [snip] > >> --- >> Cc: linux-doc@xxxxxxxxxxxxxxx >> --- >> Documentation/Makefile | 2 +- >> MAINTAINERS | 1 + >> scripts/check-variable-fonts.sh | 30 ++++++++++++++++++++++++++++++ >> 3 files changed, 32 insertions(+), 1 deletion(-) >> create mode 100755 scripts/check-variable-fonts.sh >> > > I don't have much to say about the patch except that it seems like a good idea... > > However, some of the terminology could be improved IMO. > E.g., "variable type" or "variable font" should be something like > variable-width font or proportionally-spaced font. Good point. I need to be more careful in using terms rarely found in kernel development. In this case, "variable font" means "font file which employs the OpenType font variations technology". There is a Wikipedia page at: https://en.wikipedia.org/wiki/Variable_font > > "static ones" should be something like fixed-space fonts or monospaced fonts. > > Unless I just completely don't understand the uses of "variable" and "static" here. "static" here means "non-variable". I'll expand the changelog a bit in v2 with your comments in mind. Thanks, Akira
