On Fri, 22 Mar 2024 10:17:58 +0000, David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote: > > [1 <text/plain; UTF-8 (quoted-printable)>] > On Tue, 2024-03-19 at 12:41 -0700, Oliver Upton wrote: > > On Tue, Mar 19, 2024 at 05:14:42PM +0000, David Woodhouse wrote: > > > On Tue, 2024-03-19 at 08:27 -0700, Oliver Upton wrote: > > > > If we're going down the route of having this PSCI call live in KVM, it > > > > really deserves a test. I think you can just pile on the existing > > > > psci_test selftest. > > > > > > Added to > > > https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/psci-hibernate > > > for next time. > > > > > > From 8c72a78e6179bc8970edc66a85ab6bee26f581fb Mon Sep 17 00:00:00 2001 > > > From: David Woodhouse <dwmw@xxxxxxxxxxxx> > > > Date: Tue, 19 Mar 2024 17:07:46 +0000 > > > Subject: [PATCH 4/8] KVM: selftests: Add test for PSCI SYSTEM_OFF2 > > > > > > Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx> > > > > Looks good, thanks! > > Thanks. > > Marc, I think I've also addressed your feedback? Is there anything else > to do other than wait for the spec to be published? Other than the couple of minor nits I mentioned in replies to the individual patches, this looks good to me. > Shall I post a v4 with PSCI v1.3 as default and the self-test? Would > you apply that into a branch ready for merging when the spec is ready, > or should I just wait and repost it all then? I think this can wait for the final spec. I assume that you are directly tracking this anyway, so we don't need to poll for the spec update. Thanks, M. -- Without deviation from the norm, progress is not possible.