> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Thursday, March 21, 2024 4:00 PM > To: Sabau, Radu bogdan <Radu.Sabau@xxxxxxxxxx> > Cc: Jean Delvare <jdelvare@xxxxxxxx>; Guenter Roeck <linux@xxxxxxxxxxxx>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; > Conor Dooley <conor+dt@xxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>; linux- > hwmon@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux- > i2c@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: adp1050: add bindings > > [External] > > On Wed, Mar 20, 2024 at 02:57:11PM +0200, Radu Sabau wrote: > > Add dt-bindings for adp1050 digital controller for isolated power supply > > with pmbus interface voltage, current and temperature monitor. > > > > Signed-off-by: Radu Sabau <radu.sabau@xxxxxxxxxx> > > --- > > v3: > > *Remove extra line before '$id'. > > *Remove 'address-cells' and 'size-cells' from adp1050 node. > > *Rename adp1050 node to generic name. > > *Fix typo from 'adress-cells' to 'address-cells' causing errors in the > > dt-bindings build. > > v2: > > *Fix identation for example. > > *Remove 'adi,vin-scale-monitor' and 'iin-scale-monitor' since they are not used > > anymore. > > *Fix typo for 'compatbile' to 'compatible'. > > *Add blank line under datasheet link. > > --- > > .../bindings/hwmon/pmbus/adi,adp1050.yaml | 49 +++++++++++++++++++ > > MAINTAINERS | 7 +++ > > 2 files changed, 56 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > > new file mode 100644 > > index 000000000000..42cafd8fec25 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: https://urldefense.com/v3/__https://devicetree.org/schemas/hwmon/pmbus/adi,adp1050.yaml*__;Iw!!A3Ni8CS0y2Y!- > 8d2ef4ArhRTDUHLiMXbulDz4xJmONqhQqWKLN35O7oIBsTYAjH2h1LFAT8T03nuAi97Q_kk4D5m$ > > +$schema: https://urldefense.com/v3/__https://devicetree.org/meta-schemes/core.yaml*__;Iw!!A3Ni8CS0y2Y!- > 8d2ef4ArhRTDUHLiMXbulDz4xJmONqhQqWKLN35O7oIBsTYAjH2h1LFAT8T03nuAi97Qy7d7HZZ$ > > Your issues are here. It's "http" and "meta-schemas". This is mostly > copy-n-paste, so how did you get it wrong I wonder... > I ran the build one more time yesterday and noticed that there were typos in the links, I guess it's because I decided for some reason to write them by hand (don't know why because it doesn't make any sense). > Rob
