On Thu, Mar 21, 2024 at 07:48:36AM +1300, Barry Song wrote: > On Thu, Mar 21, 2024 at 4:49 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > Stronger than that please. Just tell people not to use macros in such > > situations. Always code it in C. > While I appreciate the consistency of always using "static inline" > instead of macros, > I've noticed numerous instances of (void) macros throughout the kernel. ... > I'm uncertain whether people would find it disconcerting if they completely > deviate from the current approach. > If you believe it won't pose an issue, I can proceed with v3 to eliminate > the first option, casting to (void). It might be worth adding a note somewhere in the file that talks about how the coding style document is convering the current state of the art but some files might older and not following the current style. This isn't going to be the only thing where there'll be issues like this.
Attachment:
signature.asc
Description: PGP signature
