On Wed, 13 Mar 2024 17:22:50 -0700 Rahul Rameshbabu wrote: > I think this is for 'flag' type attributes. Not for the "header" flags > for the ethtool request, so I believe this cannot be done here, since > the header flags are a u32 type, not a flag type. > > https://lore.kernel.org/netdev/20240222134351.224704-2-jiri@xxxxxxxxxxx/ > > - > name: header > attributes: > - > name: dev-index > type: u32 > - > name: dev-name > type: string > - > name: flags > type: u32 > > vs > > - > name: bitset-bit > attributes: > - > name: index > type: u32 > - > name: name > type: string > - > name: value > type: flag > > So I believe Jiri's change applies for the latter, not the former (could > be wrong here). Ah, we're missing the enum definition and linking :S I mean: diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml index 197208f419dc..e1626c94d93b 100644 --- a/Documentation/netlink/specs/ethtool.yaml +++ b/Documentation/netlink/specs/ethtool.yaml @@ -16,6 +16,10 @@ doc: Partial family for Ethtool Netlink. name: stringset type: enum entries: [] + - + name: header-flags + type: flags + entries: [ compact-bitset, omit-reply, stats ] attribute-sets: - @@ -30,6 +34,7 @@ doc: Partial family for Ethtool Netlink. - name: flags type: u32 + enum: header-flags - name: bitset-bit See if that works and feel free to post it with my suggested-by
