[CCing Nícolas] On 07.03.24 19:10, Chris Bainbridge wrote: First off: many thx for this, much appreciated! > Append a ':' character to the first usage of "#regzbot introduced". FWIW, that is obvious and not needed here; but having it in the subject would be good. The subject also does not really match the expected style. But let's ignore that for now due the aspect mentioned below. > According to the regzbot documentation, the ':' suffix is the correct > format, and, even if not strictly necessary, it is good to be > consistent. Sadly a slightly tricky situation developed coincidentally: Nícolas not even 24 hours later send a patch that fixes this as well, but does so in a related document as well, which is wise: https://lore.kernel.org/all/20240308-regzbot-fixes-v1-1-577a4fe16e12@xxxxxxxxxxxxx/ Which leads to the question: how much do you care that you patch makes it in? If you would like to have a fresh commit in the kernel (which is totally valid thing to want!) we definitely could improve your submission and then adjust Nícolas changes on top of it -- but if you don't care at all we could just directly take Nícolas patch. Ciao, Thorsten
