On Tue, 5 Mar 2024 11:02:33 +0100 Köry Maincent wrote: > > > since we don't expect modules to call this, how about we move dev_set* > > > and the new declaration to net/core/dev.h ? > > > > Ok for me. > > I replied to quickly. > It seems this header in not include in ethtool part. > This would imply adding #include "../core/dev.h" in the tsinfo.c file. > Not sure this is what we want. It's not amazing but I think that's better than putting internal stuff in netdevice.h. ethtool is separated from core for code organization, it's not really a separate entity, it controls very core things.