>-----Original Message----- > From: Takeru Hayasaka <hayatake396@xxxxxxxxx> > Sent: Tuesday, March 5, 2024 1:18 PM > To: Pucha, HimasekharX Reddy <himasekharx.reddy.pucha@xxxxxxxxx> > Cc: Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; linux-doc@xxxxxxxxxxxxxxx; vladimir.oltean@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; laforge@xxxxxxxxxxxx; Marcin Szycik <marcin.szycik@xxxxxxxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; mailhol.vincent@xxxxxxxxxx > Subject: Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h > > Hi Himasekhar Reddy-san > > > After added the above v4 patch able to to see tab completion for flow-type but not rx-flow-hash. Please find below logs. > > Sorry. I submitted a code with the conditions reversed. I have > resubmitted it, so could you please check it again? > https://lore.kernel.org/all/20240305074350.533622-1-hayatake396@xxxxxxxxx/ > > Takeru > Hi Takeru, Its working fine with V5 patch. # ./ethtool -N eth4 flow-type ah4 ah6 esp4 esp6 ether ip4 ip6 sctp4 sctp6 tcp4 tcp6 udp4 udp6 # ./ethtool -N eth4 rx-flow-hash ah4 esp4 ether gtpc4t gtpc6t gtpu4d gtpu4u gtpu6d gtpu6u sctp6 tcp6 udp6 ah6 esp6 gtpc4 gtpc6 gtpu4 gtpu4e gtpu6 gtpu6e sctp4 tcp4 udp4 # ./ethtool -N eth4 rx-flow-hash gtpc6t d e f m n r s t v # ./ethtool -N eth4 rx-flow-hash gtpc6t d e f m n r s t v # ./ethtool -N eth4 rx-flow-hash gtpc6t sde # ./ethtool -N eth4 rx-flow-hash gtpc6t stv > 2024年3月5日(火) 13:28 Pucha, HimasekharX Reddy <himasekharx.reddy.pucha@xxxxxxxxx>: > > >-----Original Message----- > > From: Takeru Hayasaka <hayatake396@xxxxxxxxx> > > Sent: Tuesday, March 5, 2024 9:12 AM > > To: Pucha, HimasekharX Reddy <himasekharx.reddy.pucha@xxxxxxxxx> > > Cc: Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; linux-doc@xxxxxxxxxxxxxxx; vladimir.oltean@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; laforge@xxxxxxxxxxxx; Marcin Szycik <marcin.szycik@xxxxxxxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; mailhol.vincent@xxxxxxxxxx > > Subject: Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h > > > > Hi Himasekhar Reddy-san > > > > > Functionality wise its working fine. But the ethtool part (tab complete doesn't show GTP) > > > > I forgot to add the tab completion feature! Thank you for the good > > points. I've added it again in this version's patch. > > https://lore.kernel.org/all/20240305033555.524741-1-hayatake396@xxxxxxxxx/ > > > > Takeru > > > > After added the above v4 patch able to to see tab completion for flow-type but not rx-flow-hash. Please find below logs. > > # ethtool -N eth4 rx-flow-hash > ah4 ah6 esp4 esp6 ether sctp4 sctp6 tcp4 tcp6 udp4 udp6 > # ethtool -N eth4 rx-flow-hash > ah4 ah6 esp4 esp6 ether sctp4 sctp6 tcp4 tcp6 udp4 udp6 > # ethtool -N eth4 flow-type > ah4 esp4 ether gtpc4t gtpc6t gtpu4d gtpu4u gtpu6d gtpu6u ip6 sctp6 tcp6 udp6 > ah6 esp6 gtpc4 gtpc6 gtpu4 gtpu4e gtpu6 gtpu6e ip4 sctp4 tcp4 udp4 >
