On Mon, 4 Mar 2024 18:47:37 -0800 Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > On Mon, 26 Feb 2024 14:39:58 +0100 Kory Maincent wrote: > > +static DEFINE_XARRAY_FLAGS(ptp_clocks_map, XA_FLAGS_LOCK_IRQ | > > XA_FLAGS_ALLOC); > > Why _IRQ? anything on the fastpath hopefully has a pointer to the clock > already, I'd hope. And we often reserve ID 0 as invalid. To keep the same flag as IDA_INIT_FLAGS, I am not expert in xarray so I just keep it without questioning it. Do you think I should remove it? ID 0 was valid for phc. IMHO makes it invalid is not a good idea, it will change the phc id value for current board on the field. > > BTW could be a standalone patch, Xarray conversion from IDA is an > improvement in itself. Indeed. Do you prefer this patch to be standalone? Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
