On Wed, 28 Feb, 2024 18:05:20 -0800 Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > On Fri, 23 Feb 2024 11:24:45 -0800 Rahul Rameshbabu wrote: >> +/** >> + * struct ethtool_ts_stats - HW timestamping statistics >> + * @layer: input field denoting whether stats should be queried from the DMA or >> + * PHY timestamping layer. Defaults to the active layer for packet >> + * timestamping. > > I think we're better off attaching this to an existing message in the > dump (using ETHTOOL_FLAG_STATS / ethtool -I), like we do for pause, > fec, etc., rather than having to build a separate hierarchy and copy > identifiers within ETHTOOL_MSG_STATS_GET. > > Sorry if I mis-directed you this way. No worries. I can do that in my v2.
