On 24/02/27 02:38PM, Christian Brauner wrote: > On Fri, Feb 23, 2024 at 11:41:52AM -0600, John Groves wrote: > > Add the famfs_internal.h include file. This contains internal data > > structures such as the per-file metadata structure (famfs_file_meta) > > and extent formats. > > > > Signed-off-by: John Groves <john@xxxxxxxxxx> > > --- > > fs/famfs/famfs_internal.h | 53 +++++++++++++++++++++++++++++++++++++++ > > Already mentioned in another reply here but adding a bunch of types such > as famfs_file_operations that aren't even defines is pretty odd. So you > should reorder this. Acknowledged, thanks. V2 will phase in only what is needed by the code in each patch. > > > 1 file changed, 53 insertions(+) > > create mode 100644 fs/famfs/famfs_internal.h > > > > diff --git a/fs/famfs/famfs_internal.h b/fs/famfs/famfs_internal.h > > new file mode 100644 > > index 000000000000..af3990d43305 > > --- /dev/null > > +++ b/fs/famfs/famfs_internal.h > > @@ -0,0 +1,53 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * famfs - dax file system for shared fabric-attached memory > > + * > > + * Copyright 2023-2024 Micron Technology, Inc. > > + * > > + * This file system, originally based on ramfs the dax support from xfs, > > + * is intended to allow multiple host systems to mount a common file system > > + * view of dax files that map to shared memory. > > + */ > > +#ifndef FAMFS_INTERNAL_H > > +#define FAMFS_INTERNAL_H > > + > > +#include <linux/atomic.h> > > +#include <linux/famfs_ioctl.h> > > + > > +#define FAMFS_MAGIC 0x87b282ff > > That needs to go into include/uapi/linux/magic.h. Done for v2. Thank you, John
