On 27/02/24 08:55, Pekka Paalanen wrote: > On Tue, 27 Feb 2024 08:44:52 -0300 > Arthur Grillo <arthurgrillo@xxxxxxxxxx> wrote: > >> On 27/02/24 06:19, Pekka Paalanen wrote: >>> On Mon, 26 Feb 2024 17:42:11 -0300 >>> Arthur Grillo <arthurgrillo@xxxxxxxxxx> wrote: >>> >>>> Now that we have a defined benchmark for testing the driver, add >>>> documentation on how to run it. >>>> >>>> Signed-off-by: Arthur Grillo <arthurgrillo@xxxxxxxxxx> >>>> --- >>>> Documentation/gpu/vkms.rst | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst >>>> index ba04ac7c2167..6d07f79f77ff 100644 >>>> --- a/Documentation/gpu/vkms.rst >>>> +++ b/Documentation/gpu/vkms.rst >>>> @@ -89,6 +89,12 @@ You can also run subtests if you do not want to run the entire test:: >>>> sudo ./build/tests/kms_flip --run-subtest basic-plain-flip --device "sys:/sys/devices/platform/vkms" >>>> sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/tests/kms_flip --run-subtest basic-plain-flip >>>> >>>> +If you are developing features that may affect performance, you can run the kms_fb_stress >>> >>> s/can/must/ >>> >>>> +benchmark:: >>> >>> before and after, and report the numbers. >> >> Did you mean to write the benchmarks logs here? > > I mean people should be required tell their before and after numbers in > either commit message (my preference) or in series cover letter (if > benchmarking commits is not useful). > > With the addition of YUV support in VKMS, maybe the benchmark needs to With the upcoming addition, I've sent a patch to arbitrarily change the formats on the benchmark via command-line options. It's not adding a new case, but maybe just this could already help. https://lore.kernel.org/all/20240226-kms_fb_stress-dev-v1-0-1c14942b1244@xxxxxxxxxx/ Best Regards, ~Arthur Grillo > start printing YUV numbers separately as a new case. > > > Thanks, > pq > >> >>> >>>> + >>>> + sudo ./build/benchmarks/kms_fb_stress --device "sys:/sys/devices/platform/vkms" >>>> + sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/benchmarks/kms_fb_stress >>> >>> Do people need to run both commands? >> >> No, they don't, just two options. >> >> Best Regards, >> ~Arthur Grillo >> >>> >>> Anyway, a good idea. >>> >>> Acked-by: Pekka Paalanen <pekka.paalanen@xxxxxxxxxxxxx> >>> >>> >>> Thanks, >>> pq >>> >>>> + >>>> TODO >>>> ==== >>>> >>>> >>>> --- >>>> base-commit: eeb8e8d9f124f279e80ae679f4ba6e822ce4f95f >>>> change-id: 20240226-bench-vkms-5b8b7aab255e >>>> >>>> Best regards, >>> >
