On Fri, 23 Feb 2024 11:24:45 -0800 Rahul Rameshbabu <rrameshbabu@xxxxxxxxxx> wrote: > Multiple network devices that support hardware timestamping appear to have > common behavior with regards to timestamp handling. Implement common Tx > hardware timestamping statistics in a tx_stats struct_group. Common Rx > hardware timestamping statistics can subsequently be implemented in a > rx_stats struct_group for ethtool_ts_stats. > > Signed-off-by: Rahul Rameshbabu <rrameshbabu@xxxxxxxxxx> > Reviewed-by: Dragos Tatulea <dtatulea@xxxxxxxxxx> > + > +const struct nla_policy ethnl_stats_get_policy[__ETHTOOL_A_STATS_CNT] = { > + [ETHTOOL_A_STATS_HEADER] = NLA_POLICY_NESTED(ethnl_header_policy), > + [ETHTOOL_A_STATS_GROUPS] = { .type = NLA_NESTED }, > + [ETHTOOL_A_STATS_SRC] = > NLA_POLICY_MAX(NLA_U32, ETHTOOL_MAC_STATS_SRC_PMAC), > + [ETHTOOL_A_STATS_LAYER] = > + NLA_POLICY_MAX(NLA_U32, ETHTOOL_TS_STATS_LAYER_PHY), > }; You should add this new netlink attributes to the specs in a new patch to be able to test it. diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml index cfe48f8d6283..118508de2c88 100644 --- a/Documentation/netlink/specs/ethtool.yaml +++ b/Documentation/netlink/specs/ethtool.yaml @@ -859,6 +859,9 @@ attribute-sets: - name: src type: u32 + - + name: layer + type: u32 - name: phc-vclocks attributes: @@ -1526,6 +1529,7 @@ operations: attributes: - header - groups + - layer reply: attributes: - header Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com