Hello Hangbin, > MAC_ADDRESS_EQUAL and __agg_has_partner are not the same thing. > > MAC_ADDRESS_EQUAL() is only same with __agg_has_partner() when verifying > agg partner mac addr with null_mac_addr. The description could be more > accurate. Thank you for kindly reply! Yes you are right my description is not clear. > Since you want to replace the null_mac_addr checking for MAC_ADDRESS_EQUAL(). > Maybe we can also replace the null_mac_addr checking in > ad_port_selection_logic(). This should be safe as the > aggregator->partner_system and port->partner_oper.system has been compared. > e.g. > ... > With this the null_mac_addr definition could be removed. This new one looks better! Will come out a v3 and test it :) -- Regards, Jones Syue | 薛懷宗 QNAP Systems, Inc.