On Fri, 16 Feb 2024 17:36:38 -0800 Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > > but why the separate header? Is it going to be used in other parts of > > > uAPI than just in ethtool? > > > > We might use it in pse core if capabilities between PoE and PoDL differ but > > I am not sure about it. > > Do you prefer to move it to ethtool header and add prefix ETHTOOL_ to the > > enum values? > > I don't know enough to have an opinion :) Whatever you end up doing, > it's probably worth documenting the reason for the choice in the commit > message? Mmh, I am still not sure of the best choice on this. I think I will move it to ethtool as you suggested. > > > > This patch is sponsored by Dent Project > > > > <dentproject@xxxxxxxxxxxxxxxxxxx> > > > > > > side-note: no objections to the line but for accounting purposes > > > (i.e. when we generate development stats) we use the Author / From > > > line exclusively. So it'd be easier to compute stats of things funded > > > by Dent if you used: > > > > > > From: Kory Maincent (Dent Project) <kory.maincent@xxxxxxxxxxx> > > > > > > but that's entirely up to you :) > > > > Does adding the line side to the SOB in the commit message is sufficient or > > should I modify the git send email config? > > I think you can sed -i s/// the patches? When the From in the email > file doesn't match your git config IIUC git will include the from line > in the body and pick it up from them. IOW it will work. The scripts look > at git author so s-o-b won't do much. Ok, I will stick to the simple sentence then. ;) Thanks for the information! Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
