On Sat, 17 Feb 2024 15:01:55 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > -required: > > - - "#pse-cells" > > + pse_pis: > > How did this appear here? Underscores are no allowed. Didn't know that, sorry. Indeed it is written in the dts-coding-style.rst, sorry for the error. > > > + type: object > > > Missing description. Ah indeed. > > + items: > > + enum: > > + - "alternative-a" > > + - "alternative-b" > > No need for quotes. Yes I saw that warning with yamllint up to date and have fixed it with for the next version. > I believe you did not test it, so I will skip reviewing the rest. I tested it and did not face any error due to the underscore with "make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=pse-controller.yaml" Did I miss something in the test options? Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
