Re: [PATCH v15 18/50] ASoC: Add SOC USB APIs for adding an USB backend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Takashi,

On 2/13/2024 2:48 AM, Takashi Iwai wrote:
On Tue, 13 Feb 2024 01:53:50 +0100,
Wesley Cheng wrote:

--- a/sound/soc/Kconfig
+++ b/sound/soc/Kconfig
@@ -76,6 +76,15 @@ config SND_SOC_UTILS_KUNIT_TEST
  config SND_SOC_ACPI
  	tristate
+config SND_SOC_USB
+	bool "SoC based USB audio offloading"
+	help
+	  Enable this option if an ASoC platform card has support to handle
+	  USB audio offloading.  This enables the SoC USB layer, which will
+	  notifies the ASoC USB DPCM backend DAI link about available USB audio
+	  devices.  Based on the notifications, sequences to enable the audio
+	  stream can be taken based on the design.

This should be tristate, and...

--- a/sound/soc/Makefile
+++ b/sound/soc/Makefile
@@ -31,6 +31,10 @@ endif
obj-$(CONFIG_SND_SOC_ACPI) += snd-soc-acpi.o +ifneq ($(CONFIG_SND_SOC_USB),)
+snd-soc-core-objs += soc-usb.o
+endif

... split it to an individual module, i.e.:

snd-soc-usb-objs := soc-usb.o
obj-$(CONFIG_SND_SOC_USB) += snd-soc-usb.o

Otherwise it'll lead to a hard-dependency to snd-soc-core on
snd-usb-audio, which is utterly unnecessary for most of other
devices.


Got it...getting this to compile as its own separate module also required some changes to the other layers I had. Anyway, I've reworked some of the dependencies with other drivers and is working fine now.

Thanks
Wesley Cheng




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux