On 13/02/2024 08:02, Christoph Winklhofer wrote: > On Mon, Feb 12, 2024 at 04:30:00PM +0100, Krzysztof Kozlowski wrote: >> On 09/02/2024 07:22, Christoph Winklhofer via B4 Relay wrote: >>> From: Christoph Winklhofer <cj.winklhofer@xxxxxxxxx> >>> >>> Add a UART 1-Wire bus driver. The driver utilizes the UART interface via >>> the Serial Device Bus to create the 1-Wire timing patterns. The driver >>> was tested on a "Raspberry Pi 3B" with a DS18B20 and on a "Variscite >>> DART-6UL" with a DS18S20 temperature sensor. >>> >>> The 1-Wire timing pattern and the corresponding UART baud-rate with the >>> interpretation of the transferred bytes are described in the document: >> >> >>> +/* >>> + * struct w1_uart_config - configuration for 1-Wire operation >>> + * >>> + * @baudrate: baud-rate returned from serdev >>> + * @delay_us: delay to complete a 1-Wire cycle (in us) >>> + * @tx_byte: byte to generate 1-Wire timing pattern >>> + */ >>> +struct w1_uart_config { >>> + unsigned int baudrate; >>> + unsigned int delay_us; >>> + u8 tx_byte; >>> +}; >>> + >>> +/* >>> + * struct w1_uart_config - w1-uart device data >> >> That's neither correct (device, not config) nor proper kerneldoc nor >> useful. Your comment repeats struct name. If you want to make it >> kerneldoc, go ahead, but then make it a full kerneldoc. >> > > Yes, sorry - will use the correct name. > >> And obviously compile with W=1. >> > > You mean the padding error of mutex, I get it with W=3 and will fix it > by moving mutex up. No, I meant W=1. Make it a kerneldoc and compile with W=1, so you will see the warning. Best regards, Krzysztof