On 09/25/13 03:50, Robert P. J. Day wrote: > On Tue, 24 Sep 2013, Randy Dunlap wrote: > >> On 09/24/13 09:27, Robert P. J. Day wrote: >>> >>> Add the exported symbols from mm/util.c to the kernel-api memory >>> management section, to pick up obvious routines like kzfree and >>> krealloc. >>> >>> Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx> >>> >> >> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> >> Thanks. >> >> BTW, I would cc: linux-mm@xxxxxxxxx and Pekka Enberg (MM maintainer). >> >>> --- >>> >>> i'm actually torn over this one -- i think it's important that the >>> memory management section of the kernel-api book include stuff like >>> kzfree and krealloc, but that also drags in things like kstrdup and >>> kmemdup. so ... thoughts? kstrdup and kmemdup should be in the kernel-api docbook IMO. There were a few others that could be omitted, but I don't think that them being added is a problem. > thanks, but i'm curious about my reservation above. i only noticed > that mm/util.c file when i generated the kernel-api manual and, in > the section related to memory management, i noticed a number of rather > obvious routines weren't mentioned, so i went looking for them and > found them in mm/util.c (krealloc, kzfree). > > at the same time, pulling in that file also pulled in kerneldoc for > things like memdup_user() and strndup_user() and so on, and it's not > entirely clear that *those* routines belonged in that same section. > > in a perfect world, i might have spent the time to distinguish > between the two by creating a new section for kernel/userspace copy > routines, and selecting routines individually for each section. i > guess that's the price you pay for throwing somewhat-unrelated > routines into the same source file. > > rday > -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
