On Wed, 31 Jan 2024 13:46:22 +0000 Takeru Hayasaka wrote: > .../device_drivers/ethernet/intel/ice.rst | 21 ++++- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 82 +++++++++++++++++++ > drivers/net/ethernet/intel/ice/ice_flow.h | 31 +++++-- > drivers/net/ethernet/intel/ice/ice_lib.c | 37 +++++++++ > include/uapi/linux/ethtool.h | 48 +++++++++++ Could you split the uAPI changes and the driver changes to two separate commits? You should post them as a patch series, but combining them into a single commit makes the uAPI addition to easy to miss. -- pw-bot: cr