> > On Mon, Jan 22, 2024 at 10:45:22AM +0200, Danielle Ratson wrote: > > > From: Ido Schimmel <idosch@xxxxxxxxxx> > > > > > > Ethtool can already retrieve information from a transceiver module > > > EEPROM by invoking the ethtool_ops::get_module_eeprom_by_page > operation. > > > Add a corresponding operation that allows ethtool to write to a > > > transceiver module EEPROM. > > > > > > The purpose of this operation is not to enable arbitrary read / > > > write access, but to allow the kernel to write to specific addresses > > > as part of transceiver module firmware flashing. In the future, more > > > functionality can be implemented on top of these read / write > > > operations. > > > > My memory is dim, but i thought we decided that since the algorithm to > > program these modules is defined in the standard, all we need to do is > > pass the firmware blob, and have an in kernel implementation of the > > algorithm. There is no need to have an arbitrary write blob to module, > > which might, or might not be abused in the future. > > O.K, back after reading more of the patches. > > If i'm understanding the code correctly, this is never exposed to userspace? Its > purely an in kernel API? It would be good to make that clear in the commit > message, and document that in the ethtool ops structure. > > Thanks > Andrew Hi Andrew, Yes, that is correct. Will add a clarification. Thanks.
