Re: [PATCH net-next 1/6] selftests: Introduce Makefile variable to list shared bash scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2024-01-24 20:46 -0800, Jakub Kicinski wrote:
> On Wed, 24 Jan 2024 12:02:17 -0500 Benjamin Poirier wrote:
> > --- a/Documentation/dev-tools/kselftest.rst
> > +++ b/Documentation/dev-tools/kselftest.rst
> > @@ -255,9 +255,19 @@ Contributing new tests (details)
> >  
> >     TEST_PROGS_EXTENDED, TEST_GEN_PROGS_EXTENDED mean it is the
> >     executable which is not tested by default.
> > +
> >     TEST_FILES, TEST_GEN_FILES mean it is the file which is used by
> >     test.
> >  
> > +   TEST_INCLUDES is similar to TEST_FILES, it lists files which should be
> > +   included when exporting or installing the tests, with the following
> > +   differences:
> > +   * symlinks to files in other directories are preserved
> > +   * the part of paths below tools/testing/selftests/ is preserved when copying
> > +     the files to the output directory
> > +   TEST_INCLUDES is meant to list dependencies located in other directories of
> > +   the selftests hierarchy.
> > +
> 
> I think that this chunk causes a warning when doing make htmldocs:
> 
> Documentation/dev-tools/kselftest.rst:267: WARNING: Unexpected indentation.
> Documentation/dev-tools/kselftest.rst:268: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Could you double-check?

You're right, thanks for pointing it out. I'll send a v2.




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux