> > +err_commit_image: > > +err_run_image: > > +err_download_image: > > +err_fw_mng_features_get: > > name labels after the target > > > + ethtool_cmis_cdb_fini(cdb); > > +err_cdb_init: > > + ethnl_module_fw_flash_ntf_err(module_fw->dev, NULL); > > +out: > > + netdev_put(module_fw->dev, &module_fw->dev_tracker); > > + module_fw->dev->module_fw_flash_in_progress = false; > > + release_firmware(module_fw->fw); > > + kfree(module_fw); > > +} > > +EXPORT_SYMBOL_GPL(ethtool_cmis_fw_update); > > does this really need to be exported? It is actually can be dropped now, thanks.