RE: [PATCH v3 2/2] tty/sysrq: Dump printk ring buffer messages via sysrq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Sreenath Vijayan
> Sent: 17 January 2024 11:14
....
>  /* Key Operations table and lock */
>  static DEFINE_SPINLOCK(sysrq_key_table_lock);
> 
> @@ -505,7 +523,7 @@ static const struct sysrq_key_op *sysrq_key_table[62] = {
>  	NULL,				/* A */
>  	NULL,				/* B */
>  	NULL,				/* C */
> -	NULL,				/* D */
> +	&sysrq_dmesg_dump_op,		/* D */
>  	NULL,				/* E */
>  	NULL,				/* F */
>  	NULL,				/* G */

That looks like it ought to use C99 initialisers:
	['D' - 'A'] = &sysrq_dmesg_dump_op,

Possible with a #define to hide the offset.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)






[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux