On Thu, Jan 4, 2024 at 8:15 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Fri, Dec 22, 2023 at 09:33:50AM +0800, baneric926@xxxxxxxxx wrote: > > From: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx> > > > > Add common fan properties bindings to a schema. > > > > Bindings for fan controllers can reference the common schema for the > > fan > > > > child nodes: > > > > patternProperties: > > "^fan@[0-2]": > > type: object > > $ref: fan-common.yaml# > > unevaluatedProperties: false > > > > Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx> > > Signed-off-by: Billy Tsai <billy_tsai@xxxxxxxxxxxxxx> > > Signed-off-by: Ban Feng <kcfeng0@xxxxxxxxxxx> > > --- > > .../devicetree/bindings/hwmon/fan-common.yaml | 76 +++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml > > Please implement my comments on v10. > Hi Rob, I saw Aspeed Billy has already added enum to below patch: https://patchwork.kernel.org/project/linux-hwmon/patch/20240108074348.735014-2-billy_tsai@xxxxxxxxxxxxxx/ Thanks, Ban
