On 12/9/23 02:02, Song, Xiongwei wrote: > > >> -----Original Message----- >> From: Vlastimil Babka <vbabka@xxxxxxx> >> Sent: Thursday, December 7, 2023 12:15 AM >> To: sxwjean@xxxxxx; 42.hyeyoo@xxxxxxxxx; cl@xxxxxxxxx; linux-mm@xxxxxxxxx >> Cc: penberg@xxxxxxxxxx; rientjes@xxxxxxxxxx; iamjoonsoo.kim@xxxxxxx; >> roman.gushchin@xxxxxxxxx; corbet@xxxxxxx; keescook@xxxxxxxxxxxx; arnd@xxxxxxxx; >> akpm@xxxxxxxxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux- >> kernel@xxxxxxxxxxxxxxx; Song, Xiongwei <Xiongwei.Song@xxxxxxxxxxxxx> >> Subject: Re: [RFC PATCH v2 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" >> >> >> On 12/3/23 01:15, sxwjean@xxxxxx wrote: >> > From: Xiongwei Song <xiongwei.song@xxxxxxxxxxxxx> >> > >> > Since the SLAB allocator has been removed, so we need to clean up the >> >> "we can clean up", as we don't really "need" >> >> > sl[au]b_$params. However, the "slab/SLAB" terms should be keep for >> > long-term rather than "slub/SLUB". Hence, we should use "slab_$param" >> >> I'd phrase it: With only one slab allocator left, it's better to use the >> generic "slab" term instead of "slub" which is an implementation detail. >> Hence ... >> >> > as the primary prefix, which is pointed out by Vlastimil Babka. For more >> > information please see [1]. >> > >> > This patch is changing the following slab parameters >> > - slub_max_order >> > - slub_min_order >> > - slub_min_objects >> > - slub_debug >> > to >> > - slab_max_order >> > - slab_min_order >> > - slab_min_objects >> > - slab_debug >> > as the primary slab parameters in >> > Documentation/admin-guide/kernel-parameters.txt and source, and rename all >> > setup functions of them too. Meanwhile, "slub_$params" can also be passed >> >> Not sure about renaming the code at this point, I would just rename the >> user-visible parameters and their documentation and any comment that refers >> to the parameters. Functions and variables can come later as part of wider >> slub/slab change if we decide to do so? > > I think we can rename these global variables: > slub_max_order, > slub_min_order, > slub_min_objects, > slub_debug > , which are used to save values that are from parameters. Because some comments > are referring to parameters, the others are referring to these global variables, which > looks inconsistent, e.g. slub_debug/slab_debug. Is it acceptable to make them > consistent? Yeah, as an additional patch. Thanks.
