On 12/11/23 09:23, Viresh Kumar wrote: > On 11-12-23, 09:09, Andreas Hindborg (Samsung) wrote: >> >> Thanks for fixing this Viresh! >> >> Viresh Kumar <viresh.kumar@xxxxxxxxxx> writes: >> >>> diff --git a/Documentation/rust/quick-start.rst b/Documentation/rust/quick-start.rst >>> index f382914f4191..dee787f92d26 100644 >>> --- a/Documentation/rust/quick-start.rst >>> +++ b/Documentation/rust/quick-start.rst >>> @@ -33,14 +33,17 @@ A particular version of the Rust compiler is required. Newer versions may or >>> may not work because, for the moment, the kernel depends on some unstable >>> Rust features. >>> >>> -If ``rustup`` is being used, enter the checked out source code directory >>> -and run:: >>> +If ``rustup`` is being used, enter the kernel build directory and run:: >>> >>> rustup override set $(scripts/min-tool-version.sh rustc) >> >> How about just specifying the path here: >> >> rustup override set --path=<build-dir> $(scripts/min-tool-version.sh rustc) > > Hmm, this sounds good too. In that case the above line can be changed to: > > "If ``rustup`` is being used, run::" > > Looks okay ? I think it should also mention that you do not need the `--path=<build-dir>`. It might be confusing for new users who do not know where the build directory is. It might also work to put both commands there (i.e. with `--path=<build-dir>` and without) and explaining what each of them do. -- Cheers, Benno
