Hi Reinette/Peter, > -----Original Message----- > From: Reinette Chatre <reinette.chatre@xxxxxxxxx> > Sent: Thursday, December 7, 2023 1:29 PM > To: Moger, Babu <Babu.Moger@xxxxxxx>; corbet@xxxxxxx; > fenghua.yu@xxxxxxxxx; tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; > bp@xxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; James Morse > <james.morse@xxxxxxx> > Cc: x86@xxxxxxxxxx; hpa@xxxxxxxxx; paulmck@xxxxxxxxxx; > rdunlap@xxxxxxxxxxxxx; tj@xxxxxxxxxx; peterz@xxxxxxxxxxxxx; > seanjc@xxxxxxxxxx; Phillips, Kim <kim.phillips@xxxxxxx>; > jmattson@xxxxxxxxxx; ilpo.jarvinen@xxxxxxxxxxxxxxx; > jithu.joseph@xxxxxxxxx; kan.liang@xxxxxxxxxxxxxxx; Dadhania, Nikunj > <nikunj.dadhania@xxxxxxx>; daniel.sneddon@xxxxxxxxxxxxxxx; > pbonzini@xxxxxxxxxx; rick.p.edgecombe@xxxxxxxxx; rppt@xxxxxxxxxx; > maciej.wieczor-retman@xxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; eranian@xxxxxxxxxx; peternewman@xxxxxxxxxx; > Giani, Dhaval <Dhaval.Giani@xxxxxxx> > Subject: Re: [PATCH 00/15] x86/resctrl : Support AMD QoS RMID Pinning > feature > > Hi Babu, > > On 12/7/2023 8:12 AM, Moger, Babu wrote: > > On 12/6/23 12:49, Reinette Chatre wrote: > >> On 12/6/2023 7:40 AM, Moger, Babu wrote: > >>> On 12/5/23 17:17, Reinette Chatre wrote: > >>>> On 11/30/2023 4:57 PM, Babu Moger wrote: > > > >>>>> b. Mount with ABMC support > >>>>> #umount /sys/fs/resctrl/ > >>>>> #mount -o abmc -t resctrl resctrl /sys/fs/resctrl/ > >>>>> > >>>> > >>>> hmmm ... so this requires the user to mount resctrl, determine if > >>>> the feature is supported, unmount resctrl, remount resctrl with feature > enabled. > >>>> Could you please elaborate what prevents this feature from being > >>>> enabled without needing to remount resctrl? > >>> > >>> Spec says > >>> "Enabling ABMC: ABMC is enabled by setting > L3_QOS_EXT_CFG.ABMC_En=1 > >>> (see Figure 19-7). When the state of ABMC_En is changed, it must be > >>> changed to the updated value on all logical processors in the QOS Domain. > >>> Upon transitions of the ABMC_En the following actions take place: > >>> All ABMC assignable bandwidth counters are reset to 0. > >>> The L3 default mode bandwidth counters are reset to 0. > >>> The L3_QOS_ABMC_CFG MSR is reset to 0." > >>> > >>> So, all the monitoring group counters will be reset. > >>> > >>> It is technically possible to enable without remount. But ABMC mode > >>> requires few new files(in each group) which I added when mounted > >>> with "-o abmc". Thought it is a better option. > >>> > >>> Otherwise we need to add these files when ABMC is supported(not when > >>> enabled). Need to add another file in /sys/fs/resctrl/info/L3_MON to > >>> enable the feature on the fly. > >>> > >>> Both are acceptable options. Any thoughts? I think we didn’t conclude on this yet. I will remove the requirement to remount the filesystem to use ABMC. That way users can move back and forth between the modes without having to remount. We need to take care of extra cleanup of states(data structure) when user moves back and forth. Hopefully, I should be able to take care of that. Thanks Babu
