Re: [PATCH v6 06/11] blksnap: handling and tracking I/O units

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +
> +static int (*const ctl_table[])(struct tracker *tracker,
> +				__u8 __user *buf, __u32 *plen) = {
> +	ctl_cbtinfo,
> +	ctl_cbtmap,
> +	ctl_cbtdirty,
> +	ctl_snapshotadd,
> +	ctl_snapshotinfo,
> +};

Please use a switch statement like the rest of the kernel.  Besides
being simple to follow it also avoid having a speculation gadget
on user controlled input.





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux