> The get/set_rxfh ethtool ops currently takes the rxfh (RSS) parameters > as direct function arguments. This will force us to change the API (and > all drivers' functions) every time some new parameters are added. > > This is part 1/2 of the fix, as suggested in [1]: > > - First simplify the code by always providing a pointer to all params > (indir, key and func); the fact that some of them may be NULL seems > like a weird historic thing or a premature optimization. > It will simplify the drivers if all pointers are always present. > > - Then make the functions take a dev pointer, and a pointer to a > single struct wrapping all arguments. The set_* should also take > an extack. > > Link: https://lore.kernel.org/netdev/20231121152906.2dd5f487@xxxxxxxxxx/ > [1] > Suggested-by: Jakub Kicinski <kuba@xxxxxxxxxx> > Suggested-by: Jacob Keller <jacob.e.keller@xxxxxxxxx> > Signed-off-by: Ahmed Zaki <ahmed.zaki@xxxxxxxxx> > --- Thanks for submitting this. For the ENA driver: Acked-by: Arthur Kiyanovski <akiyano@xxxxxxxxxx>
