Hi Greg, Sourav removed the new field from sys/device../nodeN/meminfo as you requested; however, in nodeN/vmstat fields still get appended, as there is code that displays every item in zone_stat_item, node_stat_item without option to opt-out. I mentioned it to you at LPC. In my IOMMU [1] series, there are also fields that are added to node_stat_item that as result are appended to nodeN/vmstat. Pasha [1] https://lore.kernel.org/all/20231130201504.2322355-1-pasha.tatashin@xxxxxxxxxx On Tue, Dec 5, 2023 at 9:36 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Dec 05, 2023 at 02:31:17PM -0800, Sourav Panda wrote: > > Changelog: > > v6: > > - Interface changes > > - Added per-node nr_page_metadata and > > nr_page_metadata_boot fields that are exported > > in /sys/devices/system/node/nodeN/vmstat > > Again, please do not add any new fields to existing sysfs files, that's > not going to work well. You can add a new sysfs file, that's file, but > do not continue the abuse of the sysfs api in this file. > > thanks, > > greg k-h
