Re: [PATCH 4/4] ASoC: topology: Replace fake root_device with kunit_device in tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/5/2023 8:31 AM, davidgow@xxxxxxxxxx wrote:
Using struct root_device to create fake devices for tests is something
of a hack. The new struct kunit_device is meant for this purpose, so use
it instead.

Signed-off-by: David Gow <davidgow@xxxxxxxxxx>
---
  sound/soc/soc-topology-test.c | 11 +++--------
  1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/sound/soc/soc-topology-test.c b/sound/soc/soc-topology-test.c
index 2cd3540cec04..1d7696e5bffc 100644
--- a/sound/soc/soc-topology-test.c
+++ b/sound/soc/soc-topology-test.c
@@ -10,6 +10,7 @@
  #include <sound/soc.h>
  #include <sound/soc-topology.h>
  #include <kunit/test.h>
+#include <kunit/device.h>

Nitpick:
Can we add device.h before test.h, to keep it in alphabetical order?

/* ===== HELPER FUNCTIONS =================================================== */ @@ -21,26 +22,20 @@
   */
  static struct device *test_dev;
-static struct device_driver test_drv = {
-	.name = "sound-soc-topology-test-driver",
-};
-
  static int snd_soc_tplg_test_init(struct kunit *test)
  {
-	test_dev = root_device_register("sound-soc-topology-test");
+	test_dev = kunit_device_register(test, "sound-soc-topology-test");
  	test_dev = get_device(test_dev);
  	if (!test_dev)
  		return -ENODEV;
- test_dev->driver = &test_drv;
-
  	return 0;
  }
static void snd_soc_tplg_test_exit(struct kunit *test)
  {
  	put_device(test_dev);
-	root_device_unregister(test_dev);
+	kunit_device_unregister(test, test_dev);
  }
/*






[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux