Hi Guenter -----Original Message----- From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck Sent: Monday, December 4, 2023 3:07 PM To: baneric926@xxxxxxxxx; jdelvare@xxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; corbet@xxxxxxx Cc: linux-hwmon@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; openbmc@xxxxxxxxxxxxxxxx; CS20 KWLiu <KWLIU@xxxxxxxxxxx>; CS20 KCFeng0 <KCFENG0@xxxxxxxxxxx>; DELPHINE_CHIU@xxxxxxxxxx; Bonnie_Lo@xxxxxxxxxx Subject: Re: [PATCH v1 2/2] hwmon: Driver for Nuvoton NCT736X CAUTION - External Email: Do not click links or open attachments unless you acknowledge the sender and content. On 12/3/23 21:56, baneric926@xxxxxxxxx wrote: > From: Ban Feng <kcfeng0@xxxxxxxxxxx> > > NCT736X is an I2C based hardware monitoring chip from Nuvoton. > > Signed-off-by: Ban Feng <kcfeng0@xxxxxxxxxxx> > --- [ ... ] > + hwmon_dev = devm_hwmon_device_register_with_groups(dev, > + client->name, > + data, data->groups); Please resubmit using devm_hwmon_device_register_with_info(). Drivers using deprecated APIs will not be accepted. I'll convert to devm_hwmon_device_register_with_info in PATCH v2. Guenter Thanks, Ban ________________________________ ________________________________ The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.