Thanks for your review! On Mon, 4 Dec 2023 13:51:31 +0100 Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote: > On Fri, Dec 01, 2023 at 06:10:25PM +0100, Kory Maincent wrote: > > +u32 pse_get_types(struct pse_control *psec); > > I would add here some helper function. Something like: > pse_has_podl() or pse_has_c33() Instead of pse_get_types function? It is indeed maybe cleaner to use such helper functions instead. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com