On Mon, Nov 27, 2023 at 12:56:42PM -0800, Jakub Kicinski wrote: > diff --git a/tools/net/ynl/ynl-gen-rst.py b/tools/net/ynl/ynl-gen-rst.py > index b6292109e236..2c0b80071bcd 100755 > --- a/tools/net/ynl/ynl-gen-rst.py > +++ b/tools/net/ynl/ynl-gen-rst.py > @@ -122,6 +122,11 @@ SPACE_PER_LEVEL = 4 > return "\n".join(lines) > > > +def rst_label(title) -> str: Please add the type hinting to the "title" argument. Something as: def rst_label(title: str) -> str: Other than that I am good, and feel free to add: Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>
