On Mon, 27 Nov 2023 07:14:51 -0700 Ahmed Zaki wrote: > > - First simplify the code by always providing a pointer to all params > > (indir, key and func); the fact that some of them may be NULL seems > > like a weird historic thing or a premature optimization. > > It will simplify the drivers if all pointers are always present. > > You don't have to remove the if () checks in the existing drivers. > > > > - Then make the functions take a dev pointer, and a pointer to a > > single struct wrapping all arguments. The set_* should also take > > an extack. > > Can we skip the "extack" part for this series? There is no > "ETHTOOL_MSG_RSS_SET" netlink message, which is needed for user-space to > get the ACK and adding all the netlink stuff seems a bit out of scope. Fair point, yes, that's fine. BTW, Ed, this series will conflict with your RSS context rework. Not sure if it is on your radar.
