On Tue, 14 Nov 2023 12:28:43 +0100 Kory Maincent wrote:
> + if (!tb[ETHTOOL_A_TS_LAYER])
> + return 0;
GENL_REQ_ATTR_CHECK(), not sure why anyone would issue this command
without any useful attr.
> + /* Disable time stamping in the current layer. */
> + if (netif_device_present(dev) &&
> + (dev->ts_layer == PHY_TIMESTAMPING ||
> + dev->ts_layer == MAC_TIMESTAMPING)) {
> + ret = dev_set_hwtstamp_phylib(dev, &config, info->extack);
> + if (ret < 0)
> + return ret;
So you only support PHYLIB?
The semantics need to be better documented :(
