Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Luo Jie <quic_luoj@xxxxxxxxxxx>
Subject: Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Sat, 18 Nov 2023 16:22:14 -0800
Cc: <andrew@xxxxxxx>, <davem@xxxxxxxxxxxxx>, <edumazet@xxxxxxxxxx>, <pabeni@xxxxxxxxxx>, <robh+dt@xxxxxxxxxx>, <krzysztof.kozlowski+dt@xxxxxxxxxx>, <conor+dt@xxxxxxxxxx>, <hkallweit1@xxxxxxxxx>, <linux@xxxxxxxxxxxxxxx>, <corbet@xxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-doc@xxxxxxxxxxxxxxx>
In-reply-to: <20231118062754.2453-5-quic_luoj@quicinc.com>
References: <20231118062754.2453-1-quic_luoj@quicinc.com> <20231118062754.2453-5-quic_luoj@quicinc.com>

On Sat, 18 Nov 2023 14:27:52 +0800 Luo Jie wrote:
> +static inline bool phydev_id_is_qca808x(struct phy_device *phydev)

Please drop the "inline" keyword. The compiler will decide what's best.

Follow-Ups:
- Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x
  - From: Jie Luo

References:
- [PATCH v5 0/6] add qca8084 ethernet phy driver
  - From: Luo Jie
- [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x
  - From: Luo Jie

Prev by Date: Re: [PATCH net-next 6/9] netlink: specs: Expand the pse netlink command with PoE interface
Next by Date: Re: [PATCH v5 3/6] net: phy: at803x: add QCA8084 ethernet phy support
Previous by thread: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x
Next by thread: Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]

Powered by Linux