On Thu, Nov 09, 2023 at 07:24:00AM +0100, Javier Carrasco wrote: > Hello, > > On 09.11.23 01:02, Guenter Roeck wrote: > > On 11/8/23 07:37, Javier Carrasco wrote: > >> Add min_alarm and max_alarm attributes for humidityX to support devices > >> that can generate these alarms. > >> Such attributes already exist for other magnitudes such as tempX. > >> > >> Tested with a ChipCap 2 temperature-humidity sensor. > >> > > > > No objection, but the new attributes also need to be added to the ABI > > documentation at > > Documentation/ABI/testing/sysfs-class-hwmon and > > Documentation/hwmon/sysfs-interface.rst > > > > Which made me notice that humidityX_alarm isn't documented either. > > Please document that attribute as well while you are at it. > > > > Thanks, > > Guenter > > > Actually there are several attributes without ABI documentation or at > least the attributes enum is much larger than the objects in the ABI > documentation (in testing/sysfs-class-hwmon). > For humidity there is only input, enable, rated_min and rated_max. Are > some attributes not described for a good reason or should all be > documented? the current humidity_attributes contains: > > hwmon_humidity_enable -> documented in sysfs-class-hwmon > hwmon_humidity_input -> documented in sysfs-class-hwmon > hwmon_humidity_label > hwmon_humidity_min > hwmon_humidity_min_hyst > hwmon_humidity_max > hwmon_humidity_max_hyst > hwmon_humidity_alarm > hwmon_humidity_fault > hwmon_humidity_rated_min -> documented in sysfs-class-hwmon > hwmon_humidity_rated_max -> documented in sysfs-class-hwmon > > I could not find the temperature counterparts of my new additions > (temp_min_alarm and temp_max_alarm). > > Should all be added to sysfs-class-hwmon or am I missing some other > document? I am alright adding the ones I mentioned. > They should all be documented. It would be great if you volunteer to add the missing ones, but that won't be a mandate. I just don't want the situation to get worse. Thanks, Guenter
